Open max107 opened 5 months ago
@rfratto latest docker image main-6e4a9b9 from https://github.com/grafana/agent/issues/6044 issue
@max107 I'm not sure this is a bug; you need to configure both cert_file
and key_file
when use_tls
is enabled, but I don't see either set on your config.
Our documentation doesn't mention this, so I'm going to relabel this as a docs issue.
@rfratto we don't have cert_file & key_file, we have only ca (root cert). Please see example in docker-compose above, original kafka exporter work without any problem with ca only.
Our documentation doesn't mention this, so I'm going to relabel this as a docs issue.
documentation is okay, problem with configuration validator. Use ca only is absolute legit )
problem is here https://github.com/grafana/agent/blob/cce5b03b141d8bf43ca4ab473c8f07d6d9136b3d/pkg/integrations/kafka_exporter/kafka_exporter.go#L134-L136, where ca field validation?
@rfratto can we confirm if this issue really is a docs issue or a code issue?
@Eve832 The documentation doesn't currently reflect the requirements in the code. There's a discussion to be had around changing those requirements, but I personally think the documentation should still be updated to reflect the state of the code today.
lets see original TLS check here
There's a discussion to be had around changing those requirements
in my opinion first step - remove custom conditions in grafana-agent exporter source code, because original exporter do the same things.
Had same issue - required to provide CA without any keys, which is completely valid configuration.
Had to apply same patch as suggested in grafana/agent#6049 to bypass it.
I think suggested PR should be merged.
assigning @clayton-cornell so this doesn't get lost in the shuffle
We still run ‘real’ Kafka exporters because of this bug. Kafka uses TLS without client certs, just for session encryption. Would love to only have grafana-agent running to monitor.
What's wrong?
impossible to use tls with ca only (without cert&key pairs)
Steps to reproduce
working docker-compose example
System information
No response
Software version
docker.io/grafana/agent:main-6e4a9b9 (ttps://github.com/grafana/agent/issues/6044)
Configuration