grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.29k stars 174 forks source link

Support Microsoft Entra Workload Identity for discovery.azure #313

Open Noahnc opened 10 months ago

Noahnc commented 10 months ago

Request

Currently, Grafana Agent flow supports OAuth and Managed Identity authentication for the resource "discovery.azure". Since Microsoft has deprecated Pod managed Identity in favour of Workload Identity, it would be great to support Workload Identities for this resource.

Use case

Allows the resource “discovery.azure” to authenticate using a Workload Identity when Grafana Agent is deployed in an AKS Cluster.

tpaschalis commented 10 months ago

Hey, thanks for opening the issue. Right now, our discovery.kubernetes component reuses the service discovery implementation from Prometheus, so we should look into upstreaming the new feature there first.

jkroepke commented 10 months ago

@tpaschalis

I raised a PR upstream to support SDK native authentication (https://github.com/prometheus/prometheus/pull/13099) which includes Workload Identity as well as any other auth method.

github-actions[bot] commented 9 months ago

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it. If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!

monaka commented 2 months ago

any progress? It looks that https://github.com/prometheus/prometheus/pull/13099 by @jkroepke was merged.