Resource attributes of agent should include `host.name` and `ip`

grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines

https://grafana.com/oss/alloy

Apache License 2.0

1.31k stars 180 forks source link

Resource attributes of agent should include `host.name` and `ip` #343

Open rfratto opened 1 year ago

rfratto commented 1 year ago

Request

Resources attributes emitted by the agent should at least include host.name and ip, which is set by other projects when using the Jaeger client.

Use case

Associate received agent spans with the specific agent who sent them when using otelcol.processor.discovery.

bboreham commented 1 year ago

What is the expected content of “ip”? (Eg on a machine with two network interfaces and v4/v6 dual-stack)

rfratto commented 11 months ago

What is the expected content of “ip”? (Eg on a machine with two network interfaces and v4/v6 dual-stack)

@bboreham Ideally it's the same behavior of whatever the Jaeger client library sets, but I do agree it can be ambiguous. IIRC Jaeger defaults to the "first" IPv4 address.

bboreham commented 11 months ago

worksonmymachine.gif