search

grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.19k stars 141 forks source link

Windows: Customize Flow command line arguments without regedit #383

Open rfratto opened 1 year ago

rfratto commented 1 year ago

Request

When Flow is installed on Windows, the set of command line arguments is hard-coded into the installer, and can only be changed by editing the registry settings.

Some users may not be able to do this if Grafana Agent Flow is installed in a tightly controlled environment where editing the registry is disallowed.

These command line arguments should be configurable without the registry, either though:

  1. A different mechanism of retrieving command-line arguments.
  2. Being able to specify command-line arguments at installation time.

Use case

Modifying Flow installations in environments where users are not permitted to change registry settings.

rfratto commented 1 year ago

Being able to specify command-line arguments at installation time.

Implementing this is going to be harder than it sounds; there need to be an overall plan for what flags the user would pass, and finding out how to write the NSIS script to map the flags to the REG_MULTI_SZ registry setting.

In general, it may be easier to find a different way to specify the arguments for the managed service.

mattdurham commented 1 year ago

We could add a silent installer parameter that takes in any number of commandline args and pushes them to registry. We would either need to add rails around command line args or accept that when overriding behavior you can get into a state where the Agent doesnt start.

github-actions[bot] commented 10 months ago

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it. If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!