Improve windows installer

grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines

https://grafana.com/oss/alloy

Apache License 2.0

1.29k stars 175 forks source link

Improve windows installer #540

Open v-zhuravlev opened 2 years ago

v-zhuravlev commented 2 years ago

During interactive windows installer, we can only enable windows_exporter on/off. So agent is not fully functional after agent setup, as it is not sending data anywhere. Config has to be updated anyway.

Since some of our users will be installing agent in interactive mode, would it great to:

add more options in windows installer to fill in prometheus/loki endpoints
enable/disable logs collection

That way agent would be reporting data right after installation is done.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity. Thank you for your contributions!

mateuszdrab commented 1 year ago

Is it possible to add an argument to the installer to configure extra arguments for the Windows service? Currently need to add -config.expand-env.

rfratto commented 1 year ago

It doesn't look like it's possible today, but we'd definitely accept a PR to add it.

cc @mattdurham

erikbaranowski commented 4 months ago

Is it possible to add an argument to the installer to configure extra arguments for the Windows service? Currently need to add -config.expand-env.

This was completed under https://github.com/grafana/agent/issues/5554