search

grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1k stars 101 forks source link

Reuse official binaries in homebrew #598

Open ptodev opened 2 months ago

ptodev commented 2 months ago

Request

The homebrew recipe for Alloy is currently building Alloy form source instead of reusing the official binaries from our releases. It would be good to reuse the official binaries - the installation would be faster, and wouldn't require installing things like Go. Maybe it also wouldn't require "node" and "yarn"?

Use case

Faster installations and simpler code.

hainenber commented 2 months ago

IIRC, you'll need to perform code signing for Alloy binaries if users want to install it on Mac. I'm not sure if there's already one in place (DEB and RPM packages are signed already)

For now, I think we can selectively reuse official binaries for Linux installation.

rfratto commented 2 months ago

I feel like it's against the Homebrew expected patterns to directly download pre-built binaries. IMO we should try to make our Formula feel as native to Homebrew as possible, although that means going through the extra work of automating building bottles for people who don't want to build from source.

github-actions[bot] commented 1 month ago

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it. If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!