grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.33k stars 182 forks source link

Align default labels between loki, prometheus, and pyroscope components #654

Open rfratto opened 5 months ago

rfratto commented 5 months ago

Request

The prometheus.scrape component adds two default labels to every metric: instance (the address of the target) and job (a descriptor for the thing being scraped, which defaults to the Alloy component ID).

Similar components (at least loki.source.file) do not have the same set of default labels.

We should:

Use case

Aligning expectations between usages of loki.source.file/prometheus.scrape/pyroscope.scrape.

github-actions[bot] commented 4 months ago

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it. If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue. The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity. Thank you for your contributions!