grafana / athena-datasource

Apache License 2.0
38 stars 12 forks source link

Fix health check #305

Closed iwysiu closed 7 months ago

iwysiu commented 8 months ago

What happened: I saved an incorrect Athena config and the health check still returned true. However, as you would expect, actually running a query with the configured datasource fails.

What you expected to happen: CheckHealth should be implemented with a simple query (maybe fetching catalogs) to make sure we can actually query with the saved config.

How to reproduce it (as minimally and precisely as possible): Save a datasource with an invalid Access and Secret Key pair, and you should observe that it saves with a Data source is working message. Then try to create a query with that datasource and it should fail.