grafana / beyla

eBPF-based autoinstrumentation of web applications and network metrics
https://grafana.com/oss/beyla-ebpf/
Apache License 2.0
1.42k stars 100 forks source link

Helm: Add if condition to avoid the configuration missing check #1207

Closed grcevski closed 1 month ago

grcevski commented 1 month ago

The following well intentioned check we have may conflict with dynamic configuration naming based on the helm version, e.g. <helm-release-name>-beyla:

{{- if and (not .Values.config.create) (eq .Values.config.name "") }}
  {{- fail "if .Values.config.name is not set, then .Values.config.create should be set to true to use default configuration" }}
{{- end }}

We should wrap this if/end with another if/end, something like if not skipConfigMapCheck which will avoid doing this check.

This is particularly useful when Beyla is deployed as part of another larger helm chart.

grcevski commented 1 month ago

CC @petewall