Closed MattFrick closed 8 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
173401b
) 81.05% compared to head (6e52ac2
) 80.58%. Report is 10 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is the basic test setup, to which I'll be adding new tests in other PRs.
This is the basic test setup, to which I'll be adding new tests in other PRs.
I tried to have a look, but I'm lacking context on the scope of this PR. Please provide more info on what it does. The test runs the TraceQL query
{ .http.method = "GET" }
so is this a basic test for HTTP server spans rather than SQL client spans?
To avoid having a mega PR that includes multiple topics, I'm including the following here that is strictly oats without any sql stuff:
Closing: content of this PR is now inside the SQL PR: https://github.com/grafana/beyla/pull/298
Closing: content of this PR is now inside the SQL PR: #298
I just reopened because having two separate PRs is much easier to review and follow. I hope you don't mind. Let's merge this PR first, the test here seems unrelated to SQL.
I've added "make oats-test" and "make oats-test-debug", which leaves the services running (for ~1h), so that they can be manually inspected, e.g. prometheus and grafana. Maybe some day we can figure out how to conditionally include docker-compose files in oats tests so that we don't have the overhead of things we don't always need when we're not debugging.
Basic hello-world smoke test. Example command line from test/oats:) sudo rm -rf build/testoutput/run && TESTCASE_BASE_PATH=/path/to/this/beyla/test/oats/yaml ginkgo -v -r