grafana / beyla

eBPF-based autoinstrumentation of web applications and network metrics
https://grafana.com/oss/beyla-ebpf/
Apache License 2.0
1.23k stars 78 forks source link

Add support for directly generating span graphs #745

Closed grcevski closed 1 month ago

grcevski commented 1 month ago

Some initial code for generation of span graphs directly from Beyla. The basic design is as follows:

TODO:

mariomac commented 1 month ago

The following PR does the merge with origin/main. It just resolves the reported conflict in the instrumenter.go file, adapting the current code to the new pipes API. Despite the big size of the PR (it adds all the changes from main into your branch), I have only slightly changed the pipeline.go and name_resolver.go files.

https://github.com/grcevski/ebpf-autoinstrument/pull/4

grcevski commented 1 month ago

The following PR does the merge with origin/main. It just resolves the reported conflict in the instrumenter.go file, adapting the current code to the new pipes API. Despite the big size of the PR (it adds all the changes from main into your branch), I have only slightly changed the pipeline.go and name_resolver.go files.

grcevski#4

Thanks a bunch Mario!

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 80.60942% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 67.91%. Comparing base (fe9ac27) to head (b517207).

Files Patch % Lines
pkg/internal/export/otel/metrics.go 55.84% 23 Missing and 11 partials :warning:
pkg/internal/export/prom/prom.go 76.11% 12 Missing and 4 partials :warning:
pkg/transform/name_resolver.go 88.23% 10 Missing and 4 partials :warning:
pkg/internal/transform/kube/db.go 90.32% 3 Missing :warning:
pkg/internal/export/otel/traces.go 87.50% 2 Missing :warning:
pkg/beyla/network_cfg.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #745 +/- ## ========================================== + Coverage 67.41% 67.91% +0.49% ========================================== Files 102 103 +1 Lines 8853 9181 +328 ========================================== + Hits 5968 6235 +267 - Misses 2445 2489 +44 - Partials 440 457 +17 ``` | [Flag](https://app.codecov.io/gh/grafana/beyla/pull/745/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | Coverage Δ | | |---|---|---| | [integration-test](https://app.codecov.io/gh/grafana/beyla/pull/745/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | `67.91% <80.60%> (+0.49%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.