grafana / beyla

eBPF-based autoinstrumentation of web applications and network metrics
https://grafana.com/oss/beyla-ebpf/
Apache License 2.0
1.19k stars 77 forks source link

Fix Go http/grpc bad data #751

Closed grcevski closed 4 weeks ago

grcevski commented 4 weeks ago

I've made a few fixes and defensive changes with this PR:

Closes https://github.com/grafana/beyla/issues/737 Closes https://github.com/grafana/beyla/issues/746 Closes https://github.com/grafana/beyla/issues/742

These fixes need to be backported to 1.4.1.

The upgrade to http2 0.24 is purposefully not done to confirm our tests pass for the old version. We can then follow-up with a PR to upgrade our http2 dependency.

mariomac commented 4 weeks ago

Amazing!! I guess that so many years of coding in languages that automatically initialize the data to zero makes us to forget that C does not do it for us! 😅