codecov-commenter
commented
3 weeks ago Codecov Report
Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.
Project coverage is 67.86%. Comparing base (
fb2c7c0) to head (1f41e5c). Report is 1 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| pkg/internal/export/otel/metrics.go | 75.00% | 2 Missing :warning: |
| pkg/internal/export/prom/prom.go | 71.42% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #764 +/- ## ========================================== - Coverage 76.28% 67.86% -8.42% ========================================== Files 111 103 -8 Lines 9326 9181 -145 ========================================== - Hits 7114 6231 -883 - Misses 1831 2492 +661 - Partials 381 458 +77 ``` | [Flag](https://app.codecov.io/gh/grafana/beyla/pull/764/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | Coverage Δ | | |---|---|---| | [integration-test](https://app.codecov.io/gh/grafana/beyla/pull/764/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | `67.86% <82.60%> (-0.57%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/grafana/beyla/pull/764/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I changed traces to prefer the hostname over the ip address, but we have configuration options to include the peer in metrics too. I made everything consistent with this change.