search

grafana / carbon-relay-ng

Fast carbon relay+aggregator with admin interfaces for making changes online - production ready
Other
467 stars 151 forks source link

standardize config file location and naming #229

Open sparr opened 7 years ago

sparr commented 7 years ago

https://packagecloud.io/raintank/raintank carbon-relay-ng the EL6 package includes /etc/carbon-relay-ng/carbon-relay-ng.conf but the packaged binary expects /etc/carbon-relay-ng.ini as its default conf file, and the upstart script doesn't specify an alternative config file path (as it does in the EL7 package systemd configuration)

(I have no idea how this is working for anyone?!?)

sparr commented 7 years ago

This seems to have broken between version 0.9.2_2 and 0.9.2_20

Dieterbe commented 7 years ago

you're right, seems that this was broken via #224

Dieterbe commented 7 years ago

@sparr I have pushed the fix. cc @ehlerst it probably worked for tim because he has config management setting up the ini file? just guessing. anyway new package with the fix should appear shortly.

ehlerst commented 7 years ago

Sorry about this guys. Yes I'm using chef to update configs.

sparr commented 7 years ago

Is there a reason the binary still expects /etc/foo.ini by default? Backwards compatibility?

Dieterbe commented 7 years ago

we haven't really made the conscious decision yet to switch from /etc/carbon-relay-ng.ini to /etc/carbon-relay-ng/carbon-relay-ng.conf across all platforms/packages/ etc. some of the distro packages use the latter. i don't know why .conf is supposedly better than .ini, but at some point we should probably make it the same everywhere. I do think it's a bit silly to create the directory if it only contains one file, but that seems to be how the distributions like it? i think the case where we need more than 1 file (e.g. a storage-schemas.conf) is not so common, but when it happens, having the directory is obviously better. so let's make up our mind. maybe it should be everywhere /etc/carbon-relay-ng/carbon-relay-ng.ini ?

ehlerst commented 7 years ago

Directory definantely the INI file maybe... As a Linux user I just assumed INI files meant windows stuff. But a little reading and it makes sense if the format consist of sections, properties and values. I may have been a little biased https://en.m.wikipedia.org/wiki/INI_file

ehlerst commented 7 years ago

Here is where the bias for me comes from at least.

find /etc/ -name '*.conf' |wc -l
147
find /etc/ -name '*.ini' |wc -l
0