search

grafana / carbon-relay-ng

Fast carbon relay+aggregator with admin interfaces for making changes online - production ready
Other
468 stars 151 forks source link

Remove toki #553

Closed mbells closed 1 month ago

mbells commented 2 months ago

Remove the toki module, replaced with a rewritten tokre. This is a tokenizer based on regular expressions. The API is similar, but not the same. The tokre module is pulled into the same repo, as there are not many users of the original code. Fixes issue https://github.com/grafana/carbon-relay-ng/issues/551

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

npazosmendez commented 1 month ago

Thank you for working on this and sorry for the delay on our end. We had an internal discussion about how to proceed about this. Fortunately, toki's maintainer just added an MIT license to the project, which I believe resolves your concern: https://github.com/taylorchu/toki/commit/36c157adcc65b5cfec7781167acbfb4ea240d469

Having that said, I will close this PR.

mbells commented 1 month ago

Thanks. We're more than happy that it was resolved by updating the license of the original package.