Please clarify 'zero-downtime restarts'

grafana / carbon-relay-ng

Fast carbon relay+aggregator with admin interfaces for making changes online - production ready

Other

467 stars 151 forks source link

Please clarify 'zero-downtime restarts' #60

Closed tbielawa closed 7 years ago

tbielawa commented 9 years ago

I understand from the README that "[carbon-relay-ng] can be restarted without dropping packets (needs testing)" but I am unclear on some things. Could you perhaps assist?

Exactly how does this zero-downtime restart work? Obviously you're not describing a 'service carbonrelayng restart' type scenario.
The README says this needs further testing, can you describe how to test this functionality?

Thanks!

Dieterbe commented 9 years ago

for this we use https://github.com/rcrowley/goagain according to the docs we should just be able to send SIGUSR2 to carbon-relay-ng and it'll restart without downtime. it's been a while since i tried it, I presume carbon-relay-ng would need some work to make it work properly again (like flush all in memory buffers before quitting)

Dieterbe commented 7 years ago

this feature was removed. see https://github.com/graphite-ng/carbon-relay-ng/releases/tag/v0.8 for details. thanks