Closed shrink closed 1 year ago
@hairyhenderson re: the lint failure, I guess we have 3 options:
storage
package to something elseStorageConfig
to Config
StorageConfig
I guess, on reflection, since Storage
is now its own package, StorageConfig
is redundant. As StorageConfig
isn't exposed for Caddy consumers, renaming StorageConfig
to Config
would be backwards compatible -- I think!
That said, I don't have a particular preference -- happy to go with whatever approach is standard for this org.
- Rename
StorageConfig
toConfig
IMO that's the best approach - go ahead with that!
IMO that's the best approach - go ahead with that!
done! The golangci
tool passed locally so it should be good to re-run the Workflows now 🤞
Closes #150
I do not believe this is a breaking change because the Caddy module will continue to execute via the
init
entrypoint which now relies on thestorage
package.I tested this branch in my non-Caddy CertMagic project using
replace
and it worked as a drop-in replacement:After merge, the package can be added to the CertMagic wik: https://github.com/caddyserver/certmagic/wiki/Storage-Implementations