Open Arunachalam-J opened 1 year ago
The http probes function always throws true even when the target machine is down..
Popen().returncode will always give None inside context manager. Instead we can go with Popen().wait() - this will return actual return code.
I think the same issue is there in actions.py file also.. the issue is more prominent in probes.py file since we use this in steady state hypothesis.
Kindly let me know if you need more clarification.. thanks
Attached a code snippet for reference
Hi team,
Kindly review and approve my PR.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.