search

grafana / chaostoolkit-k6

https://chaostoolkit.org/drivers/k6
Apache License 2.0
13 stars 12 forks source link

Send output from Popen to an optional file instead of PIPE #3

Closed adamdabbracci closed 2 years ago

adamdabbracci commented 3 years ago

Outputting the POpen results to PIPE was causing the command to exit without executing or printing any errors. It now writes to a file that you can specify as an inputs. Also fixes what appears to be the wrong base path for the Javascript file.

Signed-off-by: Adam D'Abbracci adamdabbracci@adams-mbp.lan

codejnki commented 2 years ago

Any chance we could get this PR accepted and a new release created? The run_script action is broken in the current release and this helps to resolve it.

ciaransweet commented 2 years ago

@simskij sorry for the direct tag! We just had this issue come up for @codejnki in the chaostoolkit slack!

I don't think this project is 'dead' as you've been active so please could you take a look?

Appreciate it!

simskij commented 2 years ago

Hi @ciaranevans! No worries. However, I'm no longer involved in this project. Maybe @dgzlopes or @ppcano would be able to point you in the right direction?

ciaransweet commented 2 years ago

Appreciate the help @simskij!

ciaransweet commented 2 years ago

@adamdabbracci are you able to address the comments left on this?

adamdabbracci commented 2 years ago

@dgzlopes I think I got everything covered, do you mind taking another look? Thanks!

ciaransweet commented 2 years ago

Awesome, thanks for the responsiveness @dgzlopes and the contribution @adamdabbracci!