search

grafana / clickhouse-datasource

Grafana Plugin for ClickHouse
Apache License 2.0
127 stars 58 forks source link

Trace Detail no Longer Works #900

Closed forestsword closed 1 month ago

forestsword commented 1 month ago

Hello, after the recent update the trace detail has stopped working. I'm using the latest grafana and this plugin.

After I click on a trace to show it from the trace id list nothing is returned. The multiply function added in https://github.com/grafana/clickhouse-datasource/pull/890 I think was not fully implemented, the trace_start and trace_end also need the function added in order for the where comparison to work. Manually adding them to the generated SQL I get the trace returned.

SpencerTorres commented 1 month ago

Looking into this, thanks for the info

aangelisc commented 1 month ago

Fixed by #890 😊

forestsword commented 1 month ago

Thanks! Could we have a patch release of the plugin?

NicolasBissig commented 1 month ago

@SpencerTorres @aangelisc When is this planned to be released?

SpencerTorres commented 1 month ago

Now 😎