search

grafana / clock-panel

Clock Panel Plugin for Grafana
MIT License
95 stars 62 forks source link

Clock panel incorrect help text #114

Closed ollie-campbell closed 1 year ago

ollie-campbell commented 1 year ago

What happened: The help text on the Time Format Font size box is incorrect.

What you expected to happen: Should show the right help text

How to reproduce it (as minimally and precisely as possible): Setup a new clock panel. Remove the default '12px' text from the 'Time Format' 'Font size' text entry box. It shows help text of 'date format' which is unexpected.

Environment: Grafana version: 9.3.0 Data source type & version: Influxdb 2.6.0 OS Grafana is installed on: Ubuntu 22.04.1 LTS User OS & Browser: Windows 11 22H2 build 22621.963, Brave 1.46.144 Grafana plugins: Others:

Before: before

After: after

ollie-campbell commented 1 year ago

You get the same help text if you change the 'Clock type' to 'Custom' too. I'd expect that to be different.

usmangt commented 1 year ago

Hi @ollie-campbell,

Thanks for opening this issue.

Based on your steps of reproduction, I was also able to reproduce it on my test machine.

I will forward it now to our Engineers for further analysis.

tolzhabayev commented 1 year ago

Thanks for reporting this issue, fix is currently being reviewed here https://github.com/grafana/clock-panel/pull/116