grafana / cloudcost-exporter

Prometheus Exporter for Cloud Provider agnostic cost metrics
Apache License 2.0
31 stars 1 forks source link

Implement operational metrics #105

Open Pokom opened 8 months ago

Pokom commented 8 months ago

Unlike our cost metrics, operational metrics should be uniform across all providers and collectors. This makes dashboards and alerts a lot easier to setup, e.g. you only have one set of alerts instead of an N*M alerts(where N is providers, and M is collectors). This work has already begun with #104 which can be refactored to belong to the providers package and used by both AWS and GCP. While the current set is a nice foundation, we can extend this even further to:

We'd likely need the following labels:

Once we do this, we can update our existing operational dashboard(https://admin-ops-us-east-0.grafana-ops.net/grafana/d/1a9c0de366458599246184cf0ae8b468/cloudcost-exporter-overview?orgId=1) to use the generic metrics instead of the provider specific ones.

Pokom commented 8 months ago

Just to say, naming is hard and I'm not married to the idea of it being ...collector_api_requests..., I just don't have a better way of communicating external requests.

Pokom commented 2 months ago

This is likely related work to #222 and could follow similar implementations.