pkg/aws/costexplorer/costexplorer.go: removed the entire "Client" struct as it wasn't used anywhere
pkg/google/gcs/bucket_test.go: ignoring error not being checked, as we don't care if w.Write() fails, that's not something we're going to fix :)
Active question:
error formatting on pricing_map.go <- should these be returned? logged? Seems like returned, and the test needs to be updated. this is causing the tests to fail, but we should determine the actual correct behavior.
Closes https://github.com/grafana/cloudcost-exporter/issues/4
Adding
golangci-lint
to the project.config
Tests are still passing. Some noteworthy updates:
pkg/aws/costexplorer/costexplorer.go
: removed the entire "Client" struct as it wasn't used anywherepkg/google/gcs/bucket_test.go
: ignoring error not being checked, as we don't care if w.Write() fails, that's not something we're going to fix :)Active question:error formatting onpricing_map.go
<- should these be returned? logged? Seems like returned, and the test needs to be updated. this is causing the tests to fail, but we should determine the actual correct behavior.