search

grafana / cortex-jsonnet

Deprecated: see https://github.com/grafana/mimir/tree/main/operations/mimir instead
Apache License 2.0
74 stars 53 forks source link

Reduce ingester gRPC max concurrent streams to 10,000 #355

Closed bboreham closed 3 years ago

bboreham commented 3 years ago

What this PR does: Reduce the limit which governs the number of server calls that gRPC will run in parallel. Beyond this limit, requests will queue in the caller.

While parallelism helps to improve throughput, it is unrealistic that 100,000 operations would be able to proceed at once, considering typical CPU core counts, locking, etc.

Even 10,000 is probably too high, but changing the limit by more than one order of magnitude also seemed rash.

Checklist

bboreham commented 3 years ago

Don't merge yet - want to try it out first.

bboreham commented 3 years ago

This change was incorporated in #369.