search

grafana / cortex-jsonnet

Deprecated: see https://github.com/grafana/mimir/tree/main/operations/mimir instead
Apache License 2.0
74 stars 55 forks source link

Make ingester storage class configurable #368

Open fculpo opened 3 years ago

fculpo commented 3 years ago

Hello,

The storage class for ingester is hardcoded to 'fast'

Could we make this configurable ?

pracucci commented 3 years ago

When you use the blocks storage it's already configurable via cortex_ingester_data_disk_class (ingester pvc is overridden in tsdb.libsonnet). If you're using the chunks storage, then yes, you can open a PR to use cortex_ingester_data_disk_class in ingester.libsonnet too.

fculpo commented 3 years ago

Sorry but I don't see where/how to pass this value. The field does not exist in config.libsonnet and I don't see where tsdb.libsonnet is called from cortex.libsonnet

pracucci commented 3 years ago

The field does not exist in config.libsonnet and I don't see where tsdb.libsonnet is called from cortex.libsonnet

If you run the blocks storage, then you have to import tsdb.libsonnet explicitly after cortex.libsonnet. If you don't do it, then I guess you're running the (old and deprecated) chunks storage, so I would suggest you the following:

If you're using the chunks storage, then yes, you can open a PR to use cortex_ingester_data_disk_class in ingester.libsonnet too.

You can define cortex_ingester_data_disk_class in config.libsonnet.