Closed joeyorlando closed 5 months ago
TODO
Add selector and ref fields for the following Grafana OnCall resources:
Integration
(check that there are no other related fields)Schedule
Route
Escalation
Attention: Patch coverage is 0%
with 193 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
main@f68e88f
). Learn more about missing BASE report.
Files | Patch % | Lines |
---|---|---|
apis/oncall/v1alpha1/zz_generated.resolvers.go | 0.00% | 129 Missing :warning: |
apis/oncall/v1alpha1/zz_generated.deepcopy.go | 0.00% | 64 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description of your changes
Closes https://github.com/grafana/oncall/issues/4411
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Still a WIP.. still trying to get
make generate
to work locally to be able to test things on my local k8s cluster