grafana / crossplane-provider-grafana

Crossplane provider of https://github.com/grafana/terraform-provider-grafana
https://marketplace.upbound.io/providers/grafana/provider-grafana
Apache License 2.0
27 stars 14 forks source link

bump terraform provider version to v3.3.0 #167

Closed joeyorlando closed 4 months ago

joeyorlando commented 4 months ago

Description of your changes

Closes https://github.com/grafana/oncall/issues/4410

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 552 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5a6988e). Learn more about missing BASE report.

Files Patch % Lines
apis/sm/v1alpha1/zz_generated.deepcopy.go 0.00% 236 Missing :warning:
apis/oncall/v1alpha1/zz_generated.deepcopy.go 0.00% 144 Missing :warning:
apis/slo/v1alpha1/zz_generated.deepcopy.go 0.00% 63 Missing :warning:
apis/alerting/v1alpha1/zz_generated.deepcopy.go 0.00% 24 Missing :warning:
apis/oncall/v1alpha1/zz_generated.managed.go 0.00% 24 Missing :warning:
...ll/v1alpha1/zz_usernotificationrule_terraformed.go 0.00% 14 Missing :warning:
...oller/oncall/usernotificationrule/zz_controller.go 0.00% 13 Missing :warning:
apis/oss/v1alpha1/zz_generated.deepcopy.go 0.00% 12 Missing :warning:
apis/oss/v1alpha1/zz_generated.resolvers.go 0.00% 8 Missing :warning:
apis/oncall/v1alpha1/zz_generated.managedlist.go 0.00% 5 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #167 +/- ## ====================================== Coverage ? 0.00% ====================================== Files ? 198 Lines ? 29396 Branches ? 0 ====================================== Hits ? 0 Misses ? 29396 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/grafana/crossplane-provider-grafana/pull/167/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/grafana/crossplane-provider-grafana/pull/167/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | `0.00% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joeyorlando commented 4 months ago

I'm not entirely sure if make generate is working 100% here? I get codegen'd results but an error when running the command:

❯ make generate
15:12:51 [ .. ] generating provider schema for grafana/grafana 3.3.0
15:12:51 [ OK ] generating provider schema for grafana/grafana 3.3.0
15:12:51 [ .. ] verify go modules dependencies have expected content
all modules verified
15:12:53 [ OK ] go modules dependencies verified
15:12:53 [WARN] the source directory is not relative to the GOPATH at /Users/joeyorlando/go or you are you using symlinks. The build might run into issue. Please move the source directory to be at /Users/joeyorlando/go/src/github.com/grafana/crossplane-provider-grafana
15:12:54 [ .. ] go generate linux_arm64

Generated 48 resources!
angryjet: error: error loading packages using pattern ./...: /Users/joeyorlando/coding/grafana/crossplane-provider-grafana/apis/cloud/v1alpha1/zz_generated.managed.go:11:11: undefined: APIKey
exit status 1
apis/generate.go:31: running "go": exit status 1
15:13:12 [FAIL]
make[1]: *** [go.generate] Error 1
make: *** [generate] Error 2