grafana / crossplane-provider-grafana

Crossplane provider of https://github.com/grafana/terraform-provider-grafana. Generated by https://github.com/upbound/upjet
Apache License 2.0
26 stars 14 forks source link

Add --terraform-native-provider-path option to use shared gRPC provider #48

Closed patst closed 10 months ago

patst commented 11 months ago

Description of your changes

Add the flag --terraform-native-provider-path.

The discussions behind that are here:

The similar change was rolled out for the provider-jet-azure, provider-jet-gcp and provider-jet-aws providers (see https://github.com/crossplane/terrajet/issues/278 ).

The code is inspired by the provider-jet-aws PR (https://github.com/crossplane-contrib/provider-jet-aws/pull/182/files)

I have:

How has this code been tested

Build locally and tested the package in an AKS cluster.

julienduchesne commented 10 months ago

@patst Still needed? If you resolve conflicts, I can test it out!

patst commented 10 months ago

@julienduchesne I think we should forget about this. We tested it in one of your environments and the shared provider instance totally mixed up credentials. We ended up with dashboards in wrong instances.

I will close the PR. Thanks for asking!