I read about some resource usage and performance improvements with upjet version v0.10.0.
We have a lot of issues with that in our cluster with about 700 CR instances of the Crossplane-Grafana-Provider and I checked if that improves with the new version.
replace all imports from github.com/upbound/upjet with github.com/crossplane/upjet in order to use the new reference to EnableBetaManagementPolicies
added the EnableBetaManagementPolicies feature flag initially. (I think that one can be removed and be added separately if you prefer
change all zz_generated.managed.go files to add the ManagementPolicy getter/setter and remove the ProviderReference getter/setter. I did that manually because I wasn't able to find the command to generate them. If you can tell me the command I can regenerate them to check if the result is the same
It is a large diff because there are quite some changes in the generators.
There are some more examples generated in a examples-generated/ folder. I did not commit them yet, but can add them. This probably makes sense because they are generated on each make generate run.
Description of your changes
I read about some resource usage and performance improvements with upjet version v0.10.0.
We have a lot of issues with that in our cluster with about 700 CR instances of the Crossplane-Grafana-Provider and I checked if that improves with the new version.
I had to
go.mod
file.github.com/crossplane/crossplane-runtime
is now an rc version which seems quite okay, because the official provider use it as well (see https://github.com/upbound/provider-azure/blob/v0.38.0/go.mod)github.com/upbound/upjet
withgithub.com/crossplane/upjet
in order to use the new reference toEnableBetaManagementPolicies
EnableBetaManagementPolicies
feature flag initially. (I think that one can be removed and be added separately if you preferzz_generated.managed.go
files to add the ManagementPolicy getter/setter and remove the ProviderReference getter/setter. I did that manually because I wasn't able to find the command to generate them. If you can tell me the command I can regenerate them to check if the result is the sameIt is a large diff because there are quite some changes in the generators. There are some more examples generated in a
examples-generated/
folder. I did not commit them yet, but can add them. This probably makes sense because they are generated on eachmake generate
run.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
I ran
make reviewable
to execute the tests and tested manually on my local machine.I did a little 'performance test' which showned an performance improvement of factor 2x-3x on my local machine. For the test setup see https://github.com/patst/crossplane-grafana-perftest