search

grafana / docker-otel-lgtm

OpenTelemetry backend in a Docker image
Apache License 2.0
324 stars 60 forks source link

Move executables to non-versioned folders #60

Closed pimmerks closed 5 months ago

pimmerks commented 5 months ago

This change moves all versioned folders to non-versioned folders. The main advantage is the ability to mount config files in a standard location, instead of a location that contains each component's version.

This eases the update process of the container image, without needing to change both image tag and (for example) grafana version.

In my use-case, I run this container locally for development purposes, therefor, I would like to mount the Grafana config file where I disable the authentication, so I don't get the annoying "login with admin/admin and skip changing password".

Previously you had to: 

# Mount Grafana config in container
docker run -v "$(pwd)/grafana.ini:/otel-lgtm/grafana-v11.0.0/conf/custom.ini" grafana/otel-lgtm

Now you can use:

# Mount Grafana config in container
docker run -v "$(pwd)/grafana.ini:/otel-lgtm/grafana/conf/custom.ini" grafana/otel-lgtm
CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

zeitlinger commented 5 months ago

I disable the authentication

that would be a great feature to add!

zeitlinger commented 5 months ago

thanks for the contribution :smile: