search

grafana / docker-otel-lgtm

OpenTelemetry backend in a Docker image
Apache License 2.0
320 stars 59 forks source link

Build releases in CI #66

Closed josegonzalez closed 2 months ago

josegonzalez commented 5 months ago

I was looking to see if this supported ARM64 natively, and it looks like the tags are pushed by a user manually as shown in the output here. Ideally this would be done in CI so I could more easily add arm64 support.

Is this something ya'll would take a PR for? It'll probably need permissions from a member of the Grafana org on Docker hub to set a secret on this repo to push.

zeitlinger commented 5 months ago

we have a new setup with google artifact registry, which is just not available for public repos yet.

okolawole-ebsco commented 5 months ago

@josegonzalez Support for ARM64 was added with this issue https://github.com/grafana/docker-otel-lgtm/issues/29. I guess what left is pushing the image to a public repo.

josegonzalez commented 5 months ago

Using the Google registry is cool but I think being able to attribute builds to CI would be excellent.

Today artifacts are shipped to Docker Hub. If I made that work via CI, would such a PR be avoided by the Grafana Org?

josegonzalez commented 5 months ago

Note: you can change that to publish to any other target later. Today, the images are on docker hub, and mkaing those happen from CI is what I am trying to push towards.

zeitlinger commented 5 months ago

I don't mind an interim solution :smile:

hannahchan commented 2 months ago

Any update on this?

I just did a docker pull grafana/otel-lgtm on a Raspberry Pi only to find out the image was pull was for amd64. It would be nice if ARM images were available.

zeitlinger commented 2 months ago

we aim to provide a fix this quarter

zeitlinger commented 2 months ago

version 0.7.2 supports arm - https://github.com/grafana/docker-otel-lgtm/blob/a5c3bec5202534b6b569ca4675eb9e66bf2cedfe/.github/workflows/release.yml#L26