grafana / docker-otel-lgtm

OpenTelemetry backend in a Docker image
Apache License 2.0
324 stars 60 forks source link

No need to check for errors in golang example #85

Closed LordRahl90 closed 2 months ago

LordRahl90 commented 2 months ago

The provider creation does not return error. So no need to check the errors after creating the providers.

This subsequently means there's no need to handle errors within the function.

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

zeitlinger commented 2 months ago

thanks for the contribution

we try to keep this code in sync with https://github.com/open-telemetry/opentelemetry-go/blob/main/example/dice/otel.go - so it's probably best to suggest the simplification there