grafana / explore-logs

Repo for the Loki log exploration app
GNU Affero General Public License v3.0
236 stars 7 forks source link

fix(service-name-op): hide operator on `service_name` #467

Closed svennergr closed 2 weeks ago

svennergr commented 2 weeks ago

It's not pretty, but it works... Hiding the operator for service_name, as this one should always be an equal operator.

matyax commented 2 weeks ago

I would get rid of this code which is not really doing anything: https://github.com/grafana/explore-logs/blob/main/src/Components/IndexScene/IndexScene.tsx#L164-L174

https://github.com/grafana/explore-logs/assets/1069378/f3e88fa0-aff9-4958-8bbb-c76ee48bb0a4

svennergr commented 2 weeks ago

I would get rid of this code which is not really doing anything: https://github.com/grafana/explore-logs/blob/main/src/Components/IndexScene/IndexScene.tsx#L164-L174

You mean get rid of the condition?

matyax commented 2 weeks ago

Yeah, because only works when there's only 1 filter, otherwise it does nothing.

svennergr commented 2 weeks ago

Yeah, because only works when there's only 1 filter, otherwise it does nothing.

This: https://github.com/grafana/explore-logs/pull/467/commits/2bbd528c15ab6f3f56a4d76c556df8efb0635f81 ?