Closed matyax closed 1 week ago
Ohh this is exciting!
I was just looking at that. Some low hanging criteria could be:
I'm now working on adding a Select with a few sorting options, and direction (asc, desc).
This looks really great!!! A few questions I had @matyax:
Do we think it's best here to:
is this supposed to be open for review, looks like it's still a WIP?
is this supposed to be open for review, looks like it's still a WIP?
Today I removed the PoC part and moved on to implement the sorting criteria and direction. Will ping back when it's ready for review.
This should be ready to take a second look, now with more options for sorting, and direction. Ran out of time to add coverage, but will do tomorrow.
Notes from our call earlier:
Not enough space, shrink search bar?
Sort has no impact on single view:
Add calculated value to UI somewhere (e.g. the legend)
Made it bigger and added a tooltip.
If you don't mind, I'd prefer to take care of the other items in a follow-up PR.
Merging these changes to continue in follow UP prs.
Sorting, descending, by different criteria such as standard deviation, min, max, range, diff, etc. The available operations have been taken from those that are used for transformations.
For a given series, we can access calculations using
doStandardCalcs()
and transformations likestdDev
. With that, we offer the user different sorting options.Demo:
https://github.com/grafana/explore-logs/assets/1069378/2d9fb0dd-0399-4331-b273-3a6e2d6c0a69
Part of https://github.com/grafana/explore-logs/issues/316