Intercept banner - Githubissues

grafana / explore-logs

Repo for the Loki log exploration app

GNU Affero General Public License v3.0

236 stars 7 forks source link

Intercept banner #506

Open gtk-grafana opened 3 days ago

gtk-grafana commented 3 days ago

Fixes: https://github.com/grafana/explore-logs/issues/505

@stevendungan @zizzpudding @matryer @JStickler Please review my draft copy and let me know if we want to add/remove anything.

We'll need a link to the video as well.

stevendungan commented 3 days ago

@gtk-grafana

will the banner re-appear each session or will it remember state after it's been dismissed?
is it pinned to the top of the page, or will it move with the user as they vertically scroll?

@JStickler @zizzpudding @matryer curious your opinions, i think we could shrink the screen real estate it takes and reword the content a bit but this directionally what we want and close.l

JStickler commented 3 days ago

i think we could shrink the screen real estate it takes and reword the content a bit

I'm OK with the size. I'll take another look at the text in the morning when I'm fresh and can make good words again. 😛

gtk-grafana commented 2 days ago

will the banner re-appear each session or will it remember state after it's been dismissed?

is it pinned to the top of the page, or will it move with the user as they vertically scroll?

@JStickler @zizzpudding @matryer curious your opinions, i think we could shrink the screen real estate it takes and reword the content a bit but this directionally what we want and close.l

Its removal is saved in local storage, will show until user closes it. That is, as long as you use the same device, you'll only see it once Currently pinned to the top of the page, not fixed. I think it's annoying enough as is

stevendungan commented 2 days ago

ok, i have no further strong opinions, this does the task well enough. i'm good.

zizzpudding commented 2 days ago

A couple of thoughts.

Could you add a "don't show me again" ? If someone dismisses it without reading first, will they be able to get back to it? There are links to lots of good content here, it would be a shame to not have access to it. Maybe we should also have this information available off of a button in the ui?
Does the Github link to a repository of all known issues or does it link to "open a new issue"
I like Mat's conversational approach to the message. I'm not sure with the link to what we got right and what we got wrong.
"right" good feedback : slack channel or survey?
"wrong" bad feedback : GH issue?

gtk-grafana commented 2 days ago

@JStickler @matryer Joan and I just met, this is what we came up with:

Not sure where we'd put the video thumbnail. I'd suggest punting for now.

@stevendungan says we'll have a new video next week, I'll wait to merge until we have the public link to that.

JStickler commented 2 days ago

@gtk-grafana Looks good!