search

grafana / explore-logs

Repo for the Loki log exploration app
GNU Affero General Public License v3.0
308 stars 14 forks source link

Add conditional extension point for testing sidecar functionality #828

Closed aocenas closed 3 weeks ago

aocenas commented 1 month ago

This is an experiment to enable sidecar for Logs + other app and test it internally.

Ties in with https://github.com/grafana/explore-traces/pull/102

Needs appSidecar feature toggle and optionally timeRangeProvider for time picker sync.

https://github.com/user-attachments/assets/856501fb-6149-4b56-b0d1-bb5c6748c689

matryer commented 3 weeks ago

this is exciting - I think rather than 'Open in' buttons/dropdowns, we might be better providing a way to open it where that context appears in their data. E.g. a TraceID. This might also help build the right query in Traces.

aocenas commented 3 weeks ago

@matryer

I think rather than 'Open in' buttons/dropdowns, we might be better providing a way to open it where that context appears in their data. E.g. a TraceID. This might also help build the right query in Traces.

I totally agree but that is a bit of another rabbit hole right now so this is mainly to get something basic to try fast.

What you suggest needs a bit of work on DataLinks which because of how pervasive they are is again gonna be a bit of a chore. We also need a good way to do some sort of fallbacks, because dataLinks are defined outside of the target application right now what if the target application isn't installed? Also we probably should think about simplifying the dataLink model a bit so we don't have 3 different kinds when what they all actually do is trying to figure out the right URL to go to. So definitely on my plan to look at it, probably not something I can whip up quickly though.