search

grafana / explore-logs

Repo for the Loki log exploration app
GNU Affero General Public License v3.0
308 stars 14 forks source link

Patterns: Fix broken data link in pattern viz #831

Closed gtk-grafana closed 1 month ago

gtk-grafana commented 1 month ago

A few conflating problems here:

  1. Looks like the onClick handler was excluded by https://github.com/grafana/grafana/pull/93950/,
  2. Also the event object changed, so even without the regression this still would have broken in 11.3

Fixes: https://github.com/grafana/explore-logs/issues/827 Requires: https://github.com/grafana/grafana/pull/94815/ or grafana <= 11.2.2

event.origin.labels.name appears before the regression as well, so it should be safe for all supported versions of Grafana

matyax commented 1 month ago

Requires: https://github.com/grafana/grafana/pull/94815 or 11.2.2

The "or" is confusing me, because with the latest Grafana it still doesn't work.

gtk-grafana commented 1 month ago

@matyax it won't work with the latest grafana until https://github.com/grafana/grafana/pull/94815 has been merged in, but this PR should work with grafana <= 11.2.2

matyax commented 1 month ago

Ahhhhhhhhh, right. Brainfarted hard.