search

grafana / explore-logs

Repo for the Loki log exploration app
GNU Affero General Public License v3.0
308 stars 14 forks source link

Labels variable: Combobox #878

Closed gtk-grafana closed 1 week ago

gtk-grafana commented 2 weeks ago

Second step of breaking https://github.com/grafana/explore-logs/pull/841 into more manageable chunks.

This PR converts the ad-hoc variables to the new combobox type. This also allows users to select multiple include filters on the breakdown views using the combobox. The combobox has not been added to the service selection scene, that will happen in the next PR

matyax commented 1 week ago

Not sure if this has been discussed, but if we're adding the "Indexed" prefix, I would very much rather change the tab name to "Indexed labels" and keep "Labels" in the filters.

imagen

imagen

Or use "Indexed" in both.