search

grafana / explore-logs

Repo for the Loki log exploration app
GNU Affero General Public License v3.0
308 stars 14 forks source link

Service selection: Label selection UI #881

Closed gtk-grafana closed 2 days ago

gtk-grafana commented 2 weeks ago

Third step of breaking https://github.com/grafana/explore-logs/pull/841 into more manageable chunks.

Adds combobox to index (service selection) so users can select multiple indexed labels without requiring navigation to breakdowns.

Note: When aggregated metrics feature is enabled and toggled, the new "combobox" and new filter buttons will not display in the UI as only a single include filter is currently supported for aggregated metrics.

TODO:

gtk-grafana commented 6 days ago

The counter in the tabs doesn't seem to update accordingly.

So it looks like allowing multiple includes in the UI conflicts with the tab counts. For example I have an include filter in tab A, the volume query we run to get the number of panels will replace that value with .+ so we display all possible labels for the user to potentially filter on. If we run detected_labels with the same query, we'll get the correct counts for this and all tabs. Then I switch to tab B, the label the volume query renders for the label in tab A is no longer .+, otherwise users could include a label that is mutually exclusive with the filter in tab A, dead-ending the user and returning no data for every future query. Now in the count for tab A, we'll show the number of include filters we've added, instead of the number of possible labels the user can select, so when on tab B, the label for tab A would be 1, but when on tab A the count would be n (the cardinality of that label before any filters are applied).

Since there's not an un-confusing way to let users know that the counts used in the tabs/dropdowns are only applicable before any filters are applied, we decided to remove the counts for now, which admittedly sucks, but is arguably better then confusing users with incorrect counts. :(

gtk-grafana commented 2 days ago

When I clicked the "add to filters" buttons, I was confused for a minute expecting something to happen in the top section. Even with context about this feature, I was used to seeing filters being appended to the top, and the only change was the button becoming primary and enabled.

@matyax yeah that's my bad, I had forgot to push my most recent commit which addressed exactly this, you've got aggregated metrics enabled, and we don't currently support more then a single label filter with agg metrics. We removed all those buttons when agg metrics is enabled.

matyax commented 2 days ago

Oh, right. I'll disable it.