grafana / explore-logs

Repo for the Loki log exploration app
GNU Affero General Public License v3.0
308 stars 14 forks source link

Fields that error require refresh or navigation to be displayed again #898

Open gtk-grafana opened 3 days ago

gtk-grafana commented 3 days ago

onDetectedFieldsChange method in FieldsAggregatedBreakdownScene.tsx currently checks to see if the values of the detected_fields response change to add new fields to the panel list, however if that field errored out in a previous query and still exists in the current response, the field will not be added to the list of panels, leading to missing fields, and requiring the user to refresh, or navigate away (without using browser history which will cache the bad state) and return as a workaround to restore the expected list of fields.

Image

I would expect 84 fields to query and (attempt to) render, instead of just 16 in the above example.

To reproduce: trigger all panels to error out by adding an invalid filter, and then fix the bad filter. e.g. adding a comparison operation on a bytes field like bytes >= 0MB. Or reduce the time range after hitting a max number of series error.