Curious about colouring of datasource drop down

grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.

GNU Affero General Public License v3.0

18 stars 1 forks source link

Curious about colouring of datasource drop down #106

Closed simonswine closed 2 months ago

simonswine commented 2 months ago

Bug description

Grafana version: Grafana Enterprise (production) 🔗 v11.2.0-73830
Plugin version: v0.1.5 - 29/07/2024, 01:00:00

Steps to reproduce

In an instance with more than 3 data sources open the drop down:

Don't understand why the top one is gray.

Seems to be the same for explore-logs dropdown.

korniltsev commented 2 months ago

I also find it confusing.

I think this is the "keyboard focused" item. You can move it up and down with arrows keys.

grafakus commented 2 months ago

@simonswine can you see the same behaviour with the official Design System component?

If so, indeed it comes from what @korniltsev mentions. Not sure why the behaviour is not the same as other Design Systems (e.g Material UI where the focus is on the selected item when using the keyboard)

simonswine commented 2 months ago

Yes I can see the same behaviour, so we probably need to take it there or see it is a feature.

grafakus commented 2 months ago

Will be fixed in https://github.com/grafana/grafana/issues/91802