grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.

GNU Affero General Public License v3.0

18 stars 1 forks source link

feat(Timeseries): Add total resource consumption in legend #108

Closed grafakus closed 2 months ago

grafakus commented 2 months ago

✨ Description

Related issue(s): -

Whenever the UI displays a single timeseries, the total resource consumption is displayed in the legend:

This PR also does some refactorings to prepare the integration of the Comparison view.

📖 Summary of the changes

See diff tab for specific comments

🧪 How to test?

-

github-actions[bot] commented 2 months ago

Unit test coverage

Lines	Statements	Branches	Functions
	12.62% (470/3724)	9.83% (138/1403)	9.49% (108/1137)

simonswine commented 2 months ago

My only comment would be, I find the incosistency weird with the single value labels (again #95)

grafakus commented 2 months ago

My only comment would be, I find the incosistency weird with the single value labels (again #95)

I understand, it's a temporary state to provide a different view that I demoed to @bryanhuhta yesterday. Also, adding the total for each timeseries makes things unreadable in some cases: