grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.

GNU Affero General Public License v3.0

17 stars 1 forks source link

feat(Labels): Improve comparison flow #117

Closed grafakus closed 4 weeks ago

grafakus commented 1 month ago

✨ Description

Related issue(s): is blocked by https://github.com/grafana/explore-profiles/pull/120

This PR aims at improving the comparison flow by adding clear CTAs in the "Labels" view. When a label has been selected:

There's a new "Compare" button above the grid
Each grid panel has a "Baseline" and a "Comparison" button, to choose the target of the comparison

Once both "Baseline" & "Comparison" have been selected, the "Compare" button becomes active:

Clicking on the "Compare" button still opens a new tab with the (legacy) "Comparison Diff" view. This behaviour will be improved in https://github.com/grafana/explore-profiles/pull/119.

📖 Summary of the changes

See diff tab for specific comments.

🧪 How to test?

Manually, after checking this PR's branch locally

github-actions[bot] commented 1 month ago

Unit test coverage

Lines	Statements	Branches	Functions
	11.82% (464/3923)	9.28% (134/1443)	8.87% (107/1205)