github-actions[bot]
commented
1 month ago Unit test coverage
| Lines | Statements | Branches | Functions |
|---|---|---|---|
 |
11.12% (464/4170) | 8.6% (134/1558) | 8.32% (107/1285) |
Closed grafakus closed 2 weeks ago
github-actions[bot]
commented
1 month ago | Lines | Statements | Branches | Functions |
|---|---|---|---|
|
11.12% (464/4170) | 8.6% (134/1558) | 8.32% (107/1285) |
ifrost
commented
2 weeks ago A few minor UI issues:
| Issue | Screenshot |
|---|---|
| Bottom border of the highlight is cut off | |
| Missing padding at the bottom of comparison graph and label being positioned to high |
grafakus
commented
2 weeks ago A few minor UI issues: Bottom border of the highlight is cut off
It's been fixed in fixed in https://github.com/grafana/explore-profiles/pull/119/commits/f9791ffabfd37281901b699dd92a718d72febeb6#diff-408e010c621ad2b07badfec78e18b0eac9453f9ad586e631f85d5fdc48dae0d7R424
Missing padding at the bottom of comparison graph and label being positioned to high
I can't see the issue, which browser do you use?
grafakus
commented
2 weeks ago A few minor UI issues: Bottom border of the highlight is cut off
It's been fixed in fixed in f9791ff#diff-408e010c621ad2b07badfec78e18b0eac9453f9ad586e631f85d5fdc48dae0d7R424
Missing padding at the bottom of comparison graph and label being positioned to high
I can't see the issue, which browser do you use?
It's actually an issue with the selector that removes the border from the panel. Fixed.
✨ Description
Related issue(s): is blocked by https://github.com/grafana/explore-profiles/pull/117
This PR introduces the new comparison view:
As well as the ability to select the same item for baseline and comparison in the "Labels" view:
📖 Summary of the changes
See diff tab for specific comments.
🧪 How to test?