search

grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.
GNU Affero General Public License v3.0
17 stars 1 forks source link

feat(QueryBuilder): Enable the "in" operator #122

Open grafakus opened 4 weeks ago

grafakus commented 4 weeks ago

✨ Description

Related issue(s): blocks https://github.com/grafana/explore-profiles/pull/119

The code was there for a long time but we never enable the feature 🤷🏾‍♂️

image image image

Also, now that we'll have a native Scenes Comparison view, we might need the "in" operator for some "Include/Exclude" (from filters) actions on the panels in the "Labels" view (similar to log patterns in the Explore Logs app):

image

📖 Summary of the changes

See diff tab, mostly uncommenting code

🧪 How to test?

Manually, after checking this PR's branch locally, play with the query builder:

github-actions[bot] commented 3 weeks ago

Unit test coverage

Lines Statements Branches Functions
Coverage: 11%
 11.96% (470/3928) 9.44% (136/1440) 8.95% (108/1206)
simonswine commented 3 weeks ago

Another problem is when I actually what regexes equality =~ then they seem to be treated as in no matter what. I think it only makes sense when they don't contain any regex characters.

https://github.com/user-attachments/assets/13b62530-b284-4f20-9cd5-3b1ce5b70ab3