grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.

GNU Affero General Public License v3.0

18 stars 1 forks source link

feat(GitHubIntegration): Migrate GitHub integration to Scenes #142

Closed grafakus closed 2 months ago

grafakus commented 2 months ago

✨ Description

Related issue(s): -

This PR migrates the FunctionDetails panel to a SceneFunctionDetailsPanel Scene object

📖 Summary of the changes

Unfortunately, the PR is massive :/

Having said this... Many changes are caused by:

Fixing silly typos (e.g. camelCase typos "staktrace" vs "stackTrace")
Moving files around
Extracting (helper) functions to new files
Improving some TS types (e.g. DataSourceProxyClientBuilder)

🧪 How to test?

The build should pass
Manually, after checking this PR's branch locally, launch yarn:server to start testing the feature

I wished https://github.com/grafana/explore-profiles/pull/136 were ready but I actually discover the issue when working on the E2E tests for the GitHub integration.

github-actions[bot] commented 2 months ago

Unit test coverage

Lines	Statements	Branches	Functions
	10.64% (476/4470)	8.25% (136/1647)	8% (109/1362)