search

grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.
GNU Affero General Public License v3.0
18 stars 1 forks source link

feat: support submodules for GitHub Integration #147

Closed alsoba13 closed 1 month ago

alsoba13 commented 1 month ago

✨ Description

Related issue(s): https://github.com/grafana/pyroscope-squad/issues/173

In this PR we introduce the usage of the root path. For the GitHub integration, it's a hint on where the sources are located inside the repository. More information at https://github.com/grafana/pyroscope/pull/3531

📖 Summary of the changes

Just extracting the root_path from the version data that comes from the backend. Then send it back when searching for the file.

🧪 How to test?

Run the rideshare example from this branch: https://github.com/grafana/pyroscope/pull/3531 Select in the flame graph some function related to the rideshare example to look at. The GetFile call should include the root_path "examples/language-sdk-instrumentation/golang-push/rideshare"

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 1 month ago

Unit test coverage

Lines Statements Branches Functions
Coverage: 10%
 10.63% (476/4477) 8.21% (136/1656) 7.99% (109/1363)
alsoba13 commented 1 month ago

@ifrost was okay on merging this as well