Closed alsoba13 closed 1 month ago
Looks good! I left some first pass comments, but I think this is a decent direction.
We should also make sure we're addressing what to do if we find a
GitSession
cookie already in the browser. We could:
- leave it and use it as a fallback
- rename it
- delete it
No matter what is decided, let's be clear about how we plan on handling that case ๐
I changed the code to delete the old GitSession
cookie in the presence of the new cookie (whenever we set pyroscope_git_session
, GitSession
gets deleted)
@bryanhuhta I did the requested changes. I'm aware this solution is not perfect yet, but still wondering if payoffs deserve the effort taking into account that I was planning to revert everything related to multi-cookie support in this PR: https://github.com/grafana/explore-profiles/pull/152
How long do you expect to have this version running before merging the cleanup? I imagine myself merging the other PR before the changes in this PR hit production
We decided to change the approach and go for a full migration in one step. We'll merge both frontend and backend with the new cookie name. We don't expect to have a relevant impact on this not being fully sync, as this feature is not very popular.
Yet, we will still delete old cookie names
โจ Description
Related issue(s): https://github.com/grafana/pyroscope-squad/issues/171
Merge after datasources are able to forward new cookie name:
We are planning to rename the
GitSession
cookie to a more convenientpyroscope_git_session
.๐ Summary of the changes
pyroscope_git_session
.๐งช How to test?
GitSession
cookie name).pyroscope_git_session
instead, and check that it works as well.