grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.

GNU Affero General Public License v3.0

18 stars 1 forks source link

feat(AppHeader): Add Settings button #172

Closed grafakus closed 1 month ago

grafakus commented 1 month ago

✨ Description

Related issue(s): -

Before	After

📖 Summary of the changes

This PR makes one more step towards a single "Explore Profiles" link in the main Grafana menu by removing the "Settings" link from the main menu in favour of a "Settings" button in the app header (grouped with the "Copy shareable URL" and "Plugin info" buttons).

Additionally, this PR makes the "Exploration" buttons look more like a breadcrumb (see screenshot above).

🧪 How to test?

The new E2E test for the "Settings" button should pass

github-actions[bot] commented 1 month ago

Unit test coverage

Lines	Statements	Branches	Functions
	10.66% (412/3864)	8.32% (111/1334)	8.21% (100/1217)

ifrost commented 1 month ago

Additionally, this PR makes the "Exploration" buttons look more like a breadcrumb (see screenshot above).

What problem does it solve? Personally I find it a bit confusing why all menu items get selected when I go straight to Diff flame graph view for example.

Also using multiple primary buttons may be confusing to users (see https://grafana.com/developers/saga/components/buttons/button/#hierarchy--button-pairings)

matryer commented 1 month ago

@grafakus minor feedback, I found those multiple blue call-to-action buttons a little distracting (the breadcrumbs).

grafakus commented 1 month ago

Additionally, this PR makes the "Exploration" buttons look more like a breadcrumb (see screenshot above).

What problem does it solve? Personally I find it a bit confusing why all menu items get selected when I go straight to Diff flame graph view for example.

Also using multiple primary buttons may be confusing to users (see https://grafana.com/developers/saga/components/buttons/button/#hierarchy--button-pairings)

It's to support the main use cases and to give a sense of progression: reducing the scope from multiple services to a single flame graph

grafakus commented 1 month ago

@grafakus minor feedback, I found those multiple blue call-to-action buttons a little distracting (the breadcrumbs).

Are you also distracted by the arrows? I believe the arrows and the continuous selections go hand in hand.