search

grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.
GNU Affero General Public License v3.0
18 stars 1 forks source link

fix(QueryBuilder): Filters with regex values can be edited in place #207

Closed grafakus closed 3 weeks ago

grafakus commented 3 weeks ago

✨ Description

Related issue(s): solves https://github.com/grafana/explore-profiles/issues/206, relates to https://github.com/grafana/grafana/issues/93664

The issue stems from the fact that the Select component from the Saga design system does not initialize its input with the value passed as prop.

📖 Summary of the changes

To circumvent the problem, this PR replaces the Select component by an HTML input.

See the diff tab for specific comments.

🧪 How to test?

Manually, by checking this PR ; here's a short video:

https://github.com/user-attachments/assets/041f85eb-f0da-49b8-8566-f87aa6d9f423

github-actions[bot] commented 3 weeks ago

Unit test coverage

Lines Statements Branches Functions
Coverage: 10%
 10.65% (415/3894) 8.32% (112/1346) 8.1% (100/1234)